Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary escaped quotes in sirepo-components.js #6684

Closed
moellep opened this issue Jan 24, 2024 · 1 comment
Closed

Remove unnecessary escaped quotes in sirepo-components.js #6684

moellep opened this issue Jan 24, 2024 · 1 comment

Comments

@moellep
Copy link
Member

moellep commented Jan 24, 2024

sirepo-components.js has many templates with escaped single quotes which are no longer need escaping because the templates are defined using back-ticks.
@moellep moellep mentioned this issue Jan 24, 2024
Merged
mkeilman pushed a commit that referenced this issue Jan 26, 2024
#6684 - removed escapes
19c17d9
moellep pushed a commit that referenced this issue Feb 5, 2024
@mkeilman
#6684 - removed escapes (#6695)
41eb9ac
This was referenced Feb 6, 2024
Closed
Closed
Closed
@mkeilman
Copy link
Contributor

mkeilman commented Mar 8, 2024

This was fixed in #6695 but not closed - will do so now

@mkeilman mkeilman closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moellep @mkeilman