changing generator value shouldn't reset plots #6642
Assignees
Milestone
Comments
moellep
added a commit
that referenced
this issue
Feb 2, 2024
Moved selectedPlots from a saved model value to a plot variable. This is really just local plot state, and only persistent values should end up on the models (and also be present in the model schema). The existing plotVisibility code was confusing becuase it used "false" as visible, and was also keying off the model name which is static for a plot instance. I changed it so plotVisibility[i] is true if the plot is visible. $scope.plotLabels() should have been a normal function, rather than on $scope because it is used internally and not referenced from templated html. $scope.plotLabels() could get replaced with the existing getPlotLabels(). The code now resets plotVisibility() if the current plot labels don't match selectedPlotLabels. Replaced JSON.stringify() comparison with appState.deepEquals().
moellep
added a commit
that referenced
this issue
Feb 2, 2024
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running epicsllrf against llrfsim, if you change a generator value and submit it, the plots reset the zoom and selected values. It should keep showing the selected value with the current zoom instead.
For example, if I'm looking at a zoomed in plot of just the Forward value:
and update the generator, it is currently reseting the plot:
The text was updated successfully, but these errors were encountered: