Fix #440: various fixes for vm_devbox systemd #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
e-carlin
commented
Feb 5, 2024
- remove PrivateTmp this was causing many problems
- Type=forking the vm process forks and stays running after vagrant up exits
- vagrant reload after setting forwarded_port (need to reload for change to take)
- execStop needs to be an abspath and needs to be in /srv/vm_devbox_user. Just use a stop script and call it
- TimeoutStartSec=10min. With Type=forking the timeout is at play
- remove PrivateTmp this was causing many problems - Type=forking the vm process forks and stays running after vagrant up exits - vagrant reload after setting forwarded_port (need to reload for change to take) - execStop needs to be an abspath and needs to be in /srv/vm_devbox_user. Just use a stop script and call it - TimeoutStartSec=10min. With Type=forking the timeout is at play
robnagler
reviewed
Feb 5, 2024
| set -eou pipefail | ||
|
|
||
| vm_devbox_main() { | ||
| cd {{ this.run_d }} |
| @@ -56,6 +57,7 @@ def internal_build_write(self): | |||
| self.install_directory(z.run_d) | |||
| self.install_access(mode="500", owner=z.run_u) | |||
| self.install_resource("vm_devbox/start.sh", host_path=z.start_f) | |||
| self.install_resource("vm_devbox/start.sh", host_path=z.stop_f) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.