Output undulator structure in setup_source function in srwl_bl.py.

[bnash]

No description provided.

[bnash]

Still a problem here, before we merge.

The undulator is output from setup_source, but now calc_all doesn't work:

srwl_bl.SRWLBeamline(_name=v.name, _mag_approx=mag).calc_all(v, op)
File "/home/vagrant/src/srbright18/jupyter/srwl_bl.py", line 48, in init
raise Exception("Incorrect Magnetic Field Container structure")
Exception: Incorrect Magnetic Field Container structure

The problem is here:
https://github.com/radiasoft/SRW-light/blob/master/env/work/srw_python/srwl_bl.py#L49-#L51

[mrakitin]

I'd recommend to split the line to 2 or 3, it's hard to read.

[bnash]

Ok, I'll do that

[bnash]

Now there's a problem passing the undulator into set_und_sin due to https://github.com/radiasoft/SRW-light/blob/master/env/work/srw_python/srwl_bl.py#L283-L287

I think this is a bug. mag_approx field is deleted, then asked if it is zero. Since it doesn't exist, this gives an error.

[bnash]

After most recent fix, it looks like it works for me. But I'd appreciate a review of all the changes here.
The output of mag is now the container with the undulator. The K value can be computed with
mag.arMagFld[0].get_K()

[mrakitin]

Please remove the two images added to git:

• env/work/srw_python/uti_plot-0.png
• env/work/srw_python/uti_plot-1.png

I'm not sure the changes won't break anything... I'd recommend to use SRW from this branch and try it with Sirepo locally. If all the existing examples reproduce the results which are on alpha/beta servers, that's good to merge.

[bnash]

Ok, I removed .png files.
I will try to see how to run Sirepo locally to try the tests you suggest.

[mrakitin]

Thanks. Please also pay attention to the tabulated undulator examples.

You may also consider to run all Sirepo tests, which may help to reveal the hidden issues.

In the future it would be nice to have a solid test suite for SRW (see #4 and #5). This will help to test changes quickly.

[bnash]

I get the point about the tabulated undulator. I should understand how this is represented in python. I see the structure is created in python here