Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain label geometry for featureless label items #875

Merged
merged 3 commits into from
Aug 31, 2020
Merged

explain label geometry for featureless label items #875

merged 3 commits into from
Aug 31, 2020

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Jul 22, 2020 •
edited
Loading

I believe that this is a faithful representation of the discussion in #524

Related Issue(s): #524

Proposed Changes:

  1. Explain that geometries on label items should refer to the area considered for labeling, not the geometries of the labels

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master). (i really appreciate this checklist item 😅)
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

cholmes
cholmes approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @jisantuc!

lossyrob
lossyrob approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@lossyrob lossyrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jisantuc jisantuc merged commit 95a9717 into dev Aug 31, 2020
@jisantuc jisantuc deleted the docs/js/label-item-geometry branch August 31, 2020 18:51
@jisantuc jisantuc mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lossyrob lossyrob lossyrob approved these changes

@cholmes cholmes cholmes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jisantuc @cholmes @lossyrob