Introduce apheleia-inhibit-functions

[daanturo]

Fixes #134

(I accidentally force-pushed #135 from a shallow repo)

[raxod502]

Thanks, this will be very helpful. I think we can improve the design a little bit, though. define-globalized-minor-mode already has a feature that is intended to accomplish conditional enabling of a minor mode:

Signature
(define-globalized-minor-mode GLOBAL-MODE MODE TURN-ON [KEY VALUE]... BODY...)

Documentation
Make a global mode GLOBAL-MODE corresponding to buffer-local minor MODE.

TURN-ON is a function that will be called with no args in every buffer
and that should try to turn MODE on if applicable for that buffer.

So, if we make the TURN-ON function check apheleia--not-inhibited before calling apheleia-mode, I think it will accomplish the same, but more simply.

I don't mind changing that in your PR directly but I wanted to ask you your thoughts first.

[daanturo]

So, if we make the TURN-ON function check apheleia--not-inhibited before calling apheleia-mode, I think it will accomplish the same, but more simply.

I think that's totally fine. For me, my condition is a bit slow to run so I originally want to defer checking until saving is triggered, but I can just modify it to add to ".dir-locals-2.el" to evaluate just once anyway.

Cleaner code is superior, I'm in for define-global-minor-mode's TURN-ON.

[raxod502]

Ok, cool. Yeah, I figured that if the user desired caching then they could simply implement that in their disable-function.

[raxod502]

How does this version look to you?

[daanturo]

We may need to dump those variables into the autoloads file, else apheleia-global-mode will:

Error caused by user's config or system: ~/.config/doom/config.el, (void-variable apheleia-inhibit)

Edit: I don't think apheleia-inhibit is really needed, we can just set apheleia-inhibit-functions to '(always) locally anyway. Just a bit more verbose config (that's already relatively advanced) can lighten the maintenance burden of a variable.

[daanturo]

Ping @raxod502 , I added commit 66f30de .

[raxod502]

Yeah, sorry for the delay, that seems fine to me. Would be equally okay to autoload the variable individually.

Looks like CI is failing, let me see if I can fix that.

[raxod502]

Ah yes it's just checkdoc.

[raxod502]

Thanks!