Only process when there is output to return #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalafmt only returns stdout when there are errors, this could also help in other cases where a formatter returns incorrectly. Ideally, this would also be improved by basic error checking heuristics to work out if we need to update the buffer.
raxod502
approved these changes
Aug 21, 2022
There was a problem hiding this comment.
✨ Thanks. I updated the changelog accordingly. In my opinion, if a formatter does this then it is a bug that should be fixed upstream, but it is undeniable that the change you've suggested here is a simple way to improve the user experience in Apheleia irrespective of such bugs.
In the case of scalafmt it seems to be by design rather than a bug 😅 But yeah I do agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalafmt only returns stdout when there are errors, this could also help
in other cases where a formatter returns incorrectly.
Ideally, this would also be improved by basic error checking heuristics
to work out if we need to update the buffer.