add RadarVerifyServer #417

nickpatrick · 2024-11-26T19:00:59Z

expose startVerifyServer() and stopVerifyServer(), allowing customers to turn their Android app into a "companion app" (https://radar.com/documentation/fraud#web-and-desktop) for trackVerified() and startTrackingVerified() on mobile
uses https://github.com/Building42/Telegraph for the server. to make this optional, we use canImport() compiler directive in RadarVerifyServer.swift and a RadarSDK/Verify CocoaPods subspec
app and sever are kept alive using location background mode
bumps min iOS version to 12 and adds Swift support (already done in other branches)

Companion app v2

nickpatrick · 2024-11-30T19:37:48Z

.github/workflows/release-sdk.yml

@@ -23,10 +23,10 @@ jobs:
        run: xcodebuild clean build analyze test -workspace Example/Example.xcodeproj/project.xcworkspace -scheme RadarSDK -destination "platform=iOS Simulator,name=iPhone 15 Pro" | xcpretty

      - name: Build archive for iPhone simulator (RadarSDK)
-        run: xcodebuild archive -scheme RadarSDK -archivePath "RadarSDK-iphonesimulator.xcarchive" -sdk iphonesimulator SKIP_INSTALL=NO CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO
+        run: xcodebuild archive -scheme RadarSDK -archivePath "RadarSDK-iphonesimulator.xcarchive" -sdk iphonesimulator SKIP_INSTALL=NO CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES


For Swift support

nickpatrick · 2024-11-30T19:38:05Z

Example/Example/Info.plist

@@ -9,7 +9,7 @@
 	<key>CFBundleIdentifier</key>
 	<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
 	<key>CFBundleInfoDictionaryVersion</key>
-	<string>6.0</string>
+	<string>5.0</string>


To match SDK Swift version

nickpatrick · 2024-11-30T19:38:11Z

RadarSDK.podspec

  s.summary               = 'iOS SDK for Radar, the leading geofencing and location tracking platform'
  s.homepage              = 'https://radar.com'
  s.author                = { 'Radar Labs, Inc.' => 'support@radar.com' }
  s.platform              = :ios
  s.source                = { :git => 'https://github.com/radarlabs/radar-sdk-ios.git', :tag => s.version.to_s }
-  s.source_files          = ["RadarSDK/*.{h,m}", "RadarSDK/Internal/*.{h,m}", "RadarSDK/Include/*.h"]
+  s.source_files          = ["RadarSDK/*.{h,m,swift}", "RadarSDK/Include/*.h"]


For Swift support

nickpatrick · 2024-11-30T19:38:27Z

RadarSDK.podspec

  s.module_name           = 'RadarSDK'
  s.ios.deployment_target = '12.0'
  s.frameworks            = 'CoreLocation'
  s.requires_arc          = true
  s.license               = { :type => 'Apache-2.0' }
  s.resource_bundles      = {'RadarSDK' => ['RadarSDK/PrivacyInfo.xcprivacy']}
+  s.swift_version         = '5.0'
+
+  s.subspec 'Verify' do |ss|


Telegraph dependency added to a subspec, not the main spec

nickpatrick · 2024-11-30T19:38:47Z

RadarSDK/Include/RadarVerifiedLocationToken.h

+/**
+ The raw dictionary value of the token.
+ */
+@property (nullable, copy, nonatomic, readonly) NSDictionary *rawDict;


For the server to return the full token response

nickpatrick · 2024-11-30T19:39:49Z

RadarSDK/RadarVerifyServer.swift

+import Foundation
+import UserNotifications
+
+#if canImport(Telegraph)


Makes Telegraph dependency optional

nickpatrick · 2024-11-30T19:40:07Z

RadarSDK/RadarVerifyServer.swift

+    override init() {
+        super.init()
+
+        locationManager.delegate = self


Used to keep app alive while server is running

nickpatrick · 2024-11-30T19:40:19Z

RadarSDK/RadarVerifyServer.swift

+        response.headers["Access-Control-Allow-Methods"] = "GET, OPTIONS"
+    }
+
+    @objc func startServer(withCertData certData: Data, identityData: Data) {


Server logic basically matches Mac app

nickpatrick · 2024-11-30T19:40:31Z

RadarSDK/RadarVerifyServer.swift

+
+}
+#else
+@objc(RadarVerifyServer) class RadarVerifyServer: NSObject {


"noop" version if Telegraph dependency not included

nickpatrick · 2024-11-30T19:41:27Z

RadarSDK/RadarSDK.h

@@ -22,6 +22,7 @@ FOUNDATION_EXPORT const unsigned char RadarSDKVersionString[];
 #import "RadarEvent.h"
 #import "RadarGeofence.h"
 #import "RadarGeofenceGeometry.h"
+#import "RadarLogger.h"


Need to make RadarLogger.h public to use it in Swift

ShiCheng-Lu · 2024-12-02T17:05:46Z

RadarSDK/Radar.m

+    [[RadarLogger sharedInstance] logWithLevel:RadarLogLevelInfo type:RadarLogTypeSDKCall message:@"startVerifyServer()"];
+    [RadarUtils downloadDataFromURL:[NSURL URLWithString:@"https://s3.us-east-2.amazonaws.com/app.radar-verify.com/mac/c.der"] completionHandler:^(NSData * _Nonnull certData, NSError * _Nonnull error) {
+        [RadarUtils downloadDataFromURL:[NSURL URLWithString:@"https://s3.us-east-2.amazonaws.com/app.radar-verify.com/mac/id.p12"] completionHandler:^(NSData * _Nonnull identityData, NSError * _Nonnull error) {
+            if (!certData || !identityData) {


we should be able to do these two downloads at the same time, but it's not that big of a deal since realistically it'll only be called once per session. (not worth the complication)

KennyHuRadar · 2024-12-03T18:42:46Z

RadarSDK/RadarVerifyServer.swift

+import Telegraph
+
+@objc(RadarVerifyServer) class RadarVerifyServer: NSObject, CLLocationManagerDelegate {
+    @MainActor @objc static let sharedInstance = RadarVerifyServer()


The modifier @MainActor forces the operations here to be done on the main thread. Is there a specific need for us to do all these non UI tasks on the main thread? This may be especially problematic if the app is running in the background and iOS imposes limitations on the app's main thread utilization (watchdog may decide to crash the app).
I also noticed that we already have semaphores in this implementation as well.

KennyHuRadar · 2024-12-03T18:48:17Z

.github/workflows/release-sdk.yml


      - name: Build archive for iPhone device (RadarSDK)
-        run: xcodebuild archive -scheme RadarSDK -archivePath "RadarSDK-iphoneos.xcarchive" -sdk iphoneos SKIP_INSTALL=NO CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO
+        run: xcodebuild archive -scheme RadarSDK -archivePath "RadarSDK-iphoneos.xcarchive" -sdk iphoneos SKIP_INSTALL=NO CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO BUILD_LIBRARY_FOR_DISTRIBUTION=YES


Per our offline discussion, we need to further verify that there are no complications in our SPM distribution which relies on the compiled XCFramework. Happy to assist in the verification process if required :)

nickpatrick added 17 commits November 18, 2024 05:39

RadarVerifyServer

c0c1506

singleton

b1680b3

expose startVerifyServer() and stopVerifyServer()

3ca5c6e

verbose builds

6a8b749

undo verbose builds

6e0c29b

fix builds

c728c3b

expose in example app

0f62342

working version

f4b9770

load certs in Obj-C

dcee75f

Merge pull request #416 from radarlabs/companion-app-v2

3705b33

Companion app v2

remove Package.swift dependencies

2147743

add back empty dependencies

4f73e4d

add canImport directive

24aede3

Merge branch 'master' into companion-app-2

0c75ce7

use Swift 5

12f48b3

remove dupe

9bc7dc4

add back

bb88d8f

nickpatrick mentioned this pull request Nov 26, 2024

Companion app #413

Closed

nickpatrick marked this pull request as ready for review November 26, 2024 20:03

bump version

5c25144

nickpatrick requested review from lmeier and tjulien November 26, 2024 20:36

nickpatrick added 8 commits November 26, 2024 15:56

add BUILD_LIBRARY_FOR_DISTRIBUTION=YES

e5be4c4

bump version

3ebcdcc

add BUILD_LIBRARY_FOR_DISTRIBUTION=YES

5d233ff

bump version

f072794

fix typo

b7fadd4

fix typo

675173d

downloadData() compat

0aa8bd3

use RadarLogger

78dd600

nickpatrick changed the title ~~Companion app 2~~ add RadarVerifyServer Nov 29, 2024

nickpatrick mentioned this pull request Nov 29, 2024

add addRadarSDKVerify option radarlabs/react-native-radar#367

Open

nickpatrick added 7 commits November 30, 2024 10:16

add subspec

3bc5d92

bump version

3b363c5

fix podfile

77b20fe

add dependency to subspec

61b85a9

update dependencies

59e0c6f

update dependencies

04fac43

update dependencies

ae0462b

nickpatrick requested review from ShiCheng-Lu and KennyHuRadar November 30, 2024 19:21

nickpatrick commented Nov 30, 2024

View reviewed changes

ShiCheng-Lu reviewed Dec 2, 2024

View reviewed changes

KennyHuRadar reviewed Dec 3, 2024

View reviewed changes

nickpatrick added 4 commits December 11, 2024 00:40

bump version, add logging

958ca33

bump version

c042bc7

embed SSL cert

f2a1b1b

remove dependency

5539604

nickpatrick closed this Dec 31, 2024

nickpatrick deleted the companion-app-2 branch December 31, 2024 19:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add RadarVerifyServer #417

add RadarVerifyServer #417

nickpatrick commented Nov 26, 2024 •

edited

Loading

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

nickpatrick Nov 30, 2024

ShiCheng-Lu Dec 2, 2024

KennyHuRadar Dec 3, 2024 •

edited

Loading

KennyHuRadar Dec 3, 2024

add RadarVerifyServer #417

add RadarVerifyServer #417

Conversation

nickpatrick commented Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KennyHuRadar Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickpatrick commented Nov 26, 2024 •

edited

Loading

KennyHuRadar Dec 3, 2024 •

edited

Loading