feat: [AXIMST-11] Unit page - create header #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77e4b4c to
2cbde61
Compare
2cbde61 to
c6d20ad
Compare
There was a problem hiding this comment.
@ihor-romaniuk Looks great! An open question on the border-bottom of the SubHeader component. It is missing from the design for this page.
ruzniaievdm
approved these changes
Jan 4, 2024
PKulkoRaccoonGang
approved these changes
Jan 4, 2024
monteri
reviewed
Jan 5, 2024
GlugovGrGlib
reviewed
Jan 6, 2024
| * @param {string} blockId | ||
| * @returns {string} {`/courses/${courseId}/courseware/interactive_demonstrations/${sectionId}/1?activate_block_id=${blockId}`} | ||
| */ | ||
| export const getUnitPreviewPath = (courseId, sectionId, blockId) => ( |
There was a problem hiding this comment.
@ihor-romaniuk
I have checked, and we would need to take both links from backend
https://github.com/raccoongang/edx-platform/pull/2484/files#diff-fcd65c5bab25478ab25e92d58b53a090ec0141ef462e24bd88052917dba52cafR73
Ticket: AXIMST-221 Use view live and preview links from backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: unit page header
Youtrack: https://youtrack.raccoongang.com/issue/AXIMST-11