forked from openedx/cc2olx
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PDF blocks processing is implemented #7
Open
myhailo-chernyshov-rg
wants to merge
7
commits into
myhailochernyshov/block-types-processing-refactoring
Choose a base branch
from
myhailochernyshov/FC-0063/feat/pdf-blocks-processing-adding
base: myhailochernyshov/block-types-processing-refactoring
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c49a036
to
c5c4692
Compare
c5c4692
to
5de4a0d
Compare
1c28a30
to
e9ca44e
Compare
5de4a0d
to
1f05e91
Compare
NiedielnitsevIvan
requested changes
Jan 20, 2025
269f252
to
30075bf
Compare
NiedielnitsevIvan
approved these changes
Jan 23, 2025
bb12545
to
e81cee5
Compare
e9ca44e
to
253b223
Compare
e81cee5
to
3d8faaa
Compare
04d1408
to
1487472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are situations when some custom xBlocks not included into the default Open edX installation are installed on the target instance and they can display the Common Cartridge content. For example, PDF xBlock allows to display the PDF file directly on the course page.
So,
--content_types_with_custom_blocks
(or-c
) CLI argument is added to the converter that allows to specify the xBlock types that can be created if the corresponding Common Cartridge content corresponds them. It is allowed to specify several supported xBlocks, but onlypdf
type is supported now.Depenencies
Supporting information
FC-0063
Deadline
"None"