Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel build fixes #346

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Parallel build fixes #346

merged 2 commits into from
Oct 30, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Oct 30, 2022

Two small fixes for missing generated headers:

  mod_mgmtmode: add main.o depend on exports.h
  mod_notionflux: add mod_notionflux.o depend on exports.h

Both fixes are derived from build failures found by make --shuffle
added upcoming GNU make-4.4.

Before the change notion build failed after 2-3 build attempts on missing
exports.h if any of two fixes above is not applied.
After the change notion survived 15 rebuilds.

trofi added 2 commits October 30, 2022 08:15
Without this change `make --shuffle` (a mode for upcoming GNU make-4.4)
fails the build occasionally as:

    make[1]: Entering directory '/build/notion/mod_mgmtmode'
    gcc -g -Os -W -Wall -pedantic ... -c -o main.o main.c
    main.c:13:10: fatal error: exports.h: No such file or directory
       13 | #include "exports.h"
          |          ^~~~~~~~~~~
Without this change `make --shuffle` (a mode for upcoming GNU make-4.4)
fails the build occasionally as:

    make[1]: Entering directory '/build/notion/mod_notionflux'
    gcc -g -Os -W -Wall -pedantic ... -c -o mod_notionflux.o mod_notionflux.c
    mod_notionflux.c:35:10: fatal error: exports.h: No such file or directory
       35 | #include "exports.h"
          |          ^~~~~~~~~~~
Copy link
Owner

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@raboof raboof merged commit 26def01 into raboof:master Oct 30, 2022
@trofi trofi deleted the fix-parallel-build branch October 30, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants