Relax module version check strictness (fixes #101) #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a version number such as '4.0.2-5-g4d284b74+20210309-1735', prior to this commit notion would refuse to load modules that don't match the exact string. Now it only checks up until the first minus and prints a warning in case of a mismatch, which still pops up in a nasty window so the user knows about it but doesn't temporarily break functionality.
raboof
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a version number such as '4.0.2-5-g4d284b74+20210309-1735', prior
to this commit notion would refuse to load modules that don't match the
exact string. Now it only checks up until the first minus and prints a
warning in case of a mismatch, which still pops up in a nasty window so
the user knows about it but doesn't temporarily break functionality.