Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some colorful language #296

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Remove some colorful language #296

merged 1 commit into from
Oct 29, 2020

Conversation

raboof
Copy link
Owner

@raboof raboof commented Oct 26, 2020

While I'll admit I got a chuckle out of such comments on occasion, and it's
fine to not be all 'professional' and have some fun in the comments, I can
do without the hateful undertone.

Copy link
Collaborator

@buhl buhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

While I'll admit I got a chuckle out of such comments on occasion, and it's
fine to not be all 'professional' and have some fun in the comments, I can
do without the hateful undertone.
@raboof raboof merged commit 156633f into master Oct 29, 2020
raboof added a commit to raboof/nixpkgs that referenced this pull request Dec 21, 2020
What's New

The highlight of this release is fixing the long-standing issue
where Firefox popups would sometimes show up in the wrong place
on multi-monitor setups (https://github.com/raboof/notion/issue/59),
thanks to great detective work by @florolf . Thanks!

* Initial implementation of _NET_FRAME_EXTENTS (raboof/notion#303) @florolf/@raboof
* Fix potential livelock in do_timer_set (raboof/notion#302) @dnr

Docs

* Add more docs to cfg_notion.lua (raboof/notion#283) @raboof

Under the hood

* Trigger release drafter from github actions (raboof/notion#304) @raboof
* Remove some colorful language (raboof/notion#296) @raboof

https://github.com/raboof/notion/releases/tag/4.0.2
@raboof raboof mentioned this pull request Dec 21, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants