8.0: implement WaitForConfirmsAsync #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bollhals
commented
Jan 9, 2021
| /// We need to close the socket, otherwise attempting to unload the domain | ||
| /// could cause a CannotUnloadAppDomainException | ||
| /// </remarks> | ||
| public void HandleDomainUnload(object sender, EventArgs ea) |
bollhals
commented
Jan 9, 2021
| @@ -750,7 +741,7 @@ public void MaybeStartHeartbeatTimers() | |||
|
|
|||
| public void StartMainLoop() | |||
| { | |||
| _mainLoopTask = Task.Run((Action)MainLoop); | |||
| _mainLoopTask = Task.Factory.StartNew(MainLoop, TaskCreationOptions.LongRunning); | |||
There was a problem hiding this comment.
This forces the creation of a new thread instead of blocking one of the threadpool
bollhals
commented
Jan 9, 2021
| string s = "payload"; | ||
| if (length > s.Length) | ||
| { | ||
| s.PadRight(length); |
There was a problem hiding this comment.
This didn't work as a string is immutable and the returned new string was unused. So it always sent "payload" for all length inputs. => I removed most of the different cases (when I changed it to send the actual size it ran into timeouts due to the huge amount of data it tried to send.)
11 tasks
lukebakken
added a commit
that referenced
this pull request
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
implements a async WaitForConfirms => does not block a thread anymore while waiting.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
This change partially fixes #959. Partially due to it only fixes the wait part and not the channel open part.
(Meaning as long as not all thread pool threads are blocked in opening channels, the publish works as expected. This can be achieved by either precreating channels or pooling the channels or making sure not all threads are started at the same time, so all create a channel at the same time (I'd argue this is already given by real world scenarios))