Breaking public API change: fold IAutorecoveringConnection [back] into IConnection #943
+71
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This undoes #758 (made in response to #515). The events make more sense in the primary IConnection interface. Most users enable automatic connection recovery and asking them to cast to IAutorecoveringConnection is counter-intuitive. As suggested in #515, we add no-op add and remove handlers so that IConnection is easier to implement/mock. See #940 for the discussion. Closes #940.
lukebakken
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes #758 (introduced in response to #515).
The events make more sense in the primary IConnection interface.
Most users enable automatic connection recovery and asking them to
cast to IAutorecoveringConnection is counter-intuitive.
As suggested in #515, we add no-op add and remove handlers
so that IConnection is easier to implement/mock.
See #940 for the discussion.
Closes #940, expected to go into
7.0only.