Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BinaryTableValue to public section #880

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

BenBorn
Copy link

@BenBorn BenBorn commented Jun 24, 2020

#879

Proposed Changes

Move the BinaryTableValue class to the public section, because its returned by:
'result.BasicProperties.Headers.TryGetValue("key", out object value);'

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • [x ] Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

@pivotal-issuemaster
Copy link

@BenBorn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@BenBorn Thank you for signing the Contributor License Agreement!

@michaelklishin michaelklishin changed the title BugFix move BinaryTableValue to public section Move BinaryTableValue to public section Jun 24, 2020
Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RabbitMQ.Client.client.api is not a namespace used by this client. I don't see any updates to API approval tests either. This needs more work.

projects/RabbitMQ.Client/client/api/BinaryTableValue.cs Outdated Show resolved Hide resolved
@lukebakken lukebakken added this to the 6.1.1 milestone Jun 24, 2020
@lukebakken
Copy link
Contributor

@michaelklishin I'll wrap this one up this morning.

Move BinaryTableValue to apiApproval section
@lukebakken lukebakken force-pushed the feature/879-binarytablevalue branch from 4d152a9 to 87bb569 Compare June 24, 2020 15:38
@lukebakken
Copy link
Contributor

@BenBorn thanks!

@lukebakken lukebakken merged commit f088565 into rabbitmq:master Jun 24, 2020
lukebakken added a commit that referenced this pull request Jun 24, 2020
Move BinaryTableValue to public section

(cherry picked from commit f088565)
@lukebakken lukebakken modified the milestones: 6.1.1, 6.2.0 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants