Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert timeouts and other time intervals to TimeSpan #688

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Convert timeouts and other time intervals to TimeSpan #688

merged 2 commits into from
Jan 21, 2020

Conversation

lukebakken
Copy link
Contributor

Fixes #646

@lukebakken lukebakken added this to the 6.0.0 milestone Jan 17, 2020
@lukebakken lukebakken self-assigned this Jan 17, 2020
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-646 branch 3 times, most recently from 40d65b7 to af945ac Compare January 18, 2020 16:27
@michaelklishin michaelklishin marked this pull request as ready for review January 21, 2020 00:23
michaelklishin
michaelklishin reviewed Jan 21, 2020
View reviewed changes
projects/client/RabbitMQ.Client/src/client/impl/Connection.cs Outdated
var heartbeat = (ushort)NegotiatedMaxValue(m_factory.RequestedHeartbeat,
connectionTune.m_heartbeat);
Heartbeat = heartbeat;
TimeSpan requestedHeartbeat = m_factory.RequestedHeartbeat; // TODO LRB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is left to do here @lukebakken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably nothing, I'm wrapping this up today.

@michaelklishin michaelklishin changed the title Convert timeouts and other time intervals to TimeSpan DRAFT Convert timeouts and other time intervals to TimeSpan Jan 21, 2020
@michaelklishin
Copy link
Member

This looks good and passes all tests but there is a TODO comment in the heartbeat negotiation code so I'll consider it to be a WIP.

@lukebakken
Convert timeouts and other time intervals to TimeSpan
f25ea2d 
Fixes #646

Convert more values to TimeSpan

Finish conversion to TimeSpan

Revert "Remove NuGet.Build.Tasks.Pack"

This reverts commit 04518f1.
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-646 branch from 93b1a68 to f25ea2d Compare January 21, 2020 16:18
@lukebakken lukebakken changed the title DRAFT Convert timeouts and other time intervals to TimeSpan Convert timeouts and other time intervals to TimeSpan Jan 21, 2020
@lukebakken lukebakken merged commit f1c4a2b into master Jan 21, 2020
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-646 branch January 21, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@lukebakken lukebakken

Labels
effort-medium enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Time values should be TimeSpan
2 participants
@lukebakken @michaelklishin