Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stackoverflow when call some IFullModel._Private... methods #578

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Fix stackoverflow when call some IFullModel._Private... methods #578

merged 2 commits into from
Mar 19, 2019

Conversation

sergeyshaykhullin
Copy link
Contributor

Proposed Changes

Add some m_delegate._Private... in AutorecoveringModel

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Tried to use IFullModel._Private_ExchangeDeclare and got StackOverflowException. May be that was written for some reason or just a typo?

@michaelklishin michaelklishin merged commit 63d20f5 into rabbitmq:master Mar 19, 2019
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin michaelklishin added this to the 5.1.1 milestone Mar 19, 2019
@sergeyshaykhullin sergeyshaykhullin deleted the autorecovering_stackoverflow branch March 19, 2019 20:07
@michaelklishin
Copy link
Member

I will cherry-pick to 5.x, no need for a separate PR against that branch.

michaelklishin added a commit that referenced this pull request Mar 20, 2019
@michaelklishin
Merge pull request #578 from sergeyshaykhullin/autorecovering_stackov…
5b8ec19 
…erflow

Fix stackoverflow when call some IFullModel._Private... methods

(cherry picked from commit 63d20f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyshaykhullin @michaelklishin