Spike an exception based approach

[danielmarbach]

…urn type)

Proposed Changes

Please describe the big picture of your changes here to communicate to the
RabbitMQ team why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a much
lower chance of being accepted.

If English isn't your first language, don't worry about it and try to
communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

[lukebakken]

@danielmarbach I like this much more than a bool. Would you like me to continue? I'm assuming that we need a specific exception type, and to revert to ValueTask for the BasicPublishAsync return value.

[danielmarbach]

Please go for it. I plan to mostly stay absent from coding next week to relax my mind

I'm assuming that we need a specific exception type, and to revert to ValueTask for the BasicPublishAsync return value.

Yes I think that would be good. Maybe the exception can also propagate the sequence number as a property?

[lukebakken]

Yes I think that would be good. Maybe the exception can also propagate the sequence number as a property?

Yep, we're on the same page. Enjoy your vacation.

[lukebakken]

This is a much better approach! Merging, then I will continue via the rabbitmq-dotnet-client-1682 branch.