Ensure that arguments passed to recorded entities are copied. #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Reported here: https://groups.google.com/g/rabbitmq-users/c/hk5pJ4cKF0c * Ensure that arguments passed to a queue, exchange, binding, or consumer are copied when being recorded.
822850e to
870a1f4
Compare
Merged
lukebakken
pushed a commit
to Saibamen/rabbitmq-dotnet-client
that referenced
this pull request
Jun 27, 2024
Fixes rabbitmq#1617 Update RecordedConsumer.cs Update RecordedExchange.cs Update RecordedQueue.cs Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs Update `TestRecoveringConsumerHandlerOnConnection_EventArgumentsArePassedDown` Update projects/Unit/TestConnectionRecovery.cs
lukebakken
pushed a commit
to Saibamen/rabbitmq-dotnet-client
that referenced
this pull request
Jun 28, 2024
Fixes rabbitmq#1617 Update RecordedConsumer.cs Update RecordedExchange.cs Update RecordedQueue.cs Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs Update projects/RabbitMQ.Client/client/impl/RecordedConsumer.cs Update projects/RabbitMQ.Client/client/impl/RecordedBinding.cs Update projects/RabbitMQ.Client/client/impl/RecordedExchange.cs Update projects/RabbitMQ.Client/client/impl/RecordedQueue.cs Update `TestRecoveringConsumerHandlerOnConnection_EventArgumentsArePassedDown` Update projects/Unit/TestConnectionRecovery.cs Port test from `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here:
https://groups.google.com/g/rabbitmq-users/c/hk5pJ4cKF0c