Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API documentation of MaxMessageSize #1381

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update API documentation of MaxMessageSize #1381

merged 1 commit into from
Oct 13, 2023

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Sep 4, 2023 •
edited
Loading

Update api docs with regards Connection.MaxMessageSize and ConnectionFactory.DefaultMaxMessageSize.

Add a new constant called ConnectionFactory.MaximumMaxMessageSize for the maximum allowed value in RabbitMQ. And use a lower value for ConnectionFactory.DefaultMaxMessageSize

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

@MarcialRosales MarcialRosales marked this pull request as ready for review September 4, 2023 18:24
@MarcialRosales MarcialRosales changed the title Update api docs Update API documentation of MaxMessageSize Sep 4, 2023
lukebakken
lukebakken previously approved these changes Sep 26, 2023
View reviewed changes
@lukebakken lukebakken self-assigned this Sep 26, 2023
@lukebakken lukebakken added this to the 7.0.0 milestone Sep 26, 2023
@MarcialRosales @lukebakken
Update api docs
cb6657e 
Use default max message and size max message as
RabbitMQ does
@lukebakken lukebakken self-requested a review October 13, 2023 16:10
@lukebakken lukebakken merged commit 4b3e1ff into main Oct 13, 2023
@lukebakken lukebakken deleted the update-comment-1378 branch October 13, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcialRosales @lukebakken