Add a missing constant for NO_ROUTE #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this require |
|
Adding a constant should not require 6.6.0. |
Zerpet
approved these changes
Apr 5, 2023
|
I agree we can ship this in a patch release. Concourse seems unhappy about a missing input for RabbitMQ server. Since the build is passing fine in actions, and I'm confident that adding a constant did not break existing code, I'm going to merge bypassing branch protection. |
|
This was merged to |
lukebakken
added a commit
that referenced
this pull request
Apr 10, 2023
Even though we do not use the AMQP xml spec files, they should be updated Related to #1336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1331