Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify maximum message size #1218

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented Jun 9, 2022

Sets the default max message size to 128MiB to match the RabbitMQ default. There is no way to specify unlimited, either.

Fixes #1217

When I back-port this to 6.x I'll make sure the default is to have no limit, which is different than here.

@lukebakken lukebakken added this to the 7.0.0 milestone Jun 9, 2022
@lukebakken lukebakken requested a review from michaelklishin June 9, 2022 18:47
@lukebakken lukebakken self-assigned this Jun 9, 2022
@michaelklishin
Copy link
Member

This is a reasonable solution 👍

@lukebakken lukebakken marked this pull request as ready for review June 9, 2022 20:14
@lukebakken
Copy link
Contributor Author

Thanks @michaelklishin. It's a bit "hidden" because it's a property of AmqpTcpEndpoint but it'll do for now. For 7.0 I'd really like to revisit the whole connection, factory, endpoint shenanigans because there's just too much code.

@lukebakken lukebakken merged commit fd95377 into main Jun 9, 2022
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1217 branch June 9, 2022 20:22
@lukebakken lukebakken mentioned this pull request Jun 9, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading an unreasonably large payloadSize should throw an exception.
2 participants