Various cleanups of Connection / Model #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size of lib drops for me from |
michaelklishin
approved these changes
Jan 26, 2021
|
@bollhals this now needs a rebase against master 🙏 |
2913217 to
44c7941
Compare
done 👍 |
|
…and this now needs another rebase. |
|
Will do 😃 |
44c7941 to
7e938b6
Compare
|
done 👍 this should be ready |
11 tasks
|
Can we proceed with this or is there something to look at? |
|
@michaelklishin can we proceed with this? |
eerhardt
added a commit
to eerhardt/rabbitmq-dotnet-client
that referenced
this pull request
Jan 12, 2024
The allows the 6.x library to be used in trimmed and native AOT'd applications without any warnings. Since the 6.x branch doesn't target net6.0+, it only targets netstandard2.0 and net462, the #if NET6_0_OR_GREATER checks don't do anything. To resolve this issue, and copy the trimming attributes into this library following the recommendation at https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/#approach-2-define-the-attributes-internally. This allows the library to apply the attributes without targeting net6.0+. Also moving DebugUtil to the test project - porting rabbitmq#1009 from the main branch. Contributes to rabbitmq#1410
11 tasks
lukebakken
pushed a commit
to eerhardt/rabbitmq-dotnet-client
that referenced
this pull request
Feb 13, 2024
The allows the 6.x library to be used in trimmed and native AOT'd applications without any warnings. Since the 6.x branch doesn't target net6.0+, it only targets netstandard2.0 and net462, the #if NET6_0_OR_GREATER checks don't do anything. To resolve this issue, and copy the trimming attributes into this library following the recommendation at https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/#approach-2-define-the-attributes-internally. This allows the library to apply the attributes without targeting net6.0+. Also moving DebugUtil to the test project - porting rabbitmq#1009 from the main branch. Contributes to rabbitmq#1410 Add AotCompatibility.TestApp Add PS1 to run test app Add AOT test to windows GHA
lukebakken
pushed a commit
that referenced
this pull request
Feb 13, 2024
The allows the 6.x library to be used in trimmed and native AOT'd applications without any warnings. Since the 6.x branch doesn't target net6.0+, it only targets netstandard2.0 and net462, the #if NET6_0_OR_GREATER checks don't do anything. To resolve this issue, and copy the trimming attributes into this library following the recommendation at https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/#approach-2-define-the-attributes-internally. This allows the library to apply the attributes without targeting net6.0+. Also moving DebugUtil to the test project - porting #1009 from the main branch. Contributes to #1410 Add AotCompatibility.TestApp Add PS1 to run test app Add AOT test to windows GHA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
various smaller cleanups mainly in connection and model classes.
Types of Changes
Checklist
CONTRIBUTING.mddocumentFurther Comments
This PR contains some small public API changes!