Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify recordings in AutorecoveringConnection #1007

Merged
merged 3 commits into from
Jan 23, 2021

Conversation

bollhals
Copy link
Contributor

Proposed Changes

This PR contains 3 changes:

  • move out all code for recording out into its own partial file + some simplifications
  • caching the Default Protocol so its not getting created over and over again
  • replacing the builder pattern used in recordings

This is mostly simplification with some minor allocation improvements and code size reduction.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit ee4f334 into rabbitmq:master Jan 23, 2021
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin michaelklishin added this to the 8.0.0 milestone Jan 23, 2021
@bollhals bollhals deleted the feature/simplify.recording branch January 23, 2021 10:26
@lukebakken lukebakken modified the milestones: 8.0.0, 7.0.0 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants