Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Standard 2.0 support in addition to 1.5 #428

Closed
JBaltika opened this issue Jul 25, 2018 · 8 comments
Closed

Add .NET Standard 2.0 support in addition to 1.5 #428

JBaltika opened this issue Jul 25, 2018 · 8 comments

Comments

@JBaltika
Copy link

Hi,

Would it possible to update the nuspec for .netStandard2.0 target. Thanks.

J.B

@michaelklishin
Copy link
Member

It’s not a matter of updating the spec file. It’s a matter of cutting support for earlier .NET Standard versions. We will consider it but no offer no ETA promises.

@adamralph
Copy link
Contributor

@michaelklishin note that you can trivially add a netstandard2.0 assembly alongside the current 1.5 assembly by multitargetting, i.e. <TargetFrameworks>net451;netstandard1.5;netstandard2.0</TargetFrameworks>. This is hugely advantageous for anyone using platforms which support netstandard2.0 since they will have a much lighter dependency graph and will take advantage of the better tooling support for netstandard2.0 vs 1.x.

I'm now doing this for all OSS projects which I maintain. The 1.x and 2.0 assemblies are functionally identical. It's purely to improve the developement experience for consumers.

@kjnilsson
Copy link
Contributor

We may have to do a bit of ci work to get the release pipeline building ok but adding another target should be fine. I wonder if the latest tooling will be able to build net451 on linux without jumping through all the massive number of hoops we currently are.

@adamralph
Copy link
Contributor

AFAIK the only way to build net451 on Linux is to use Mono. After all, that's the only .NET Framework implementation outside Windows.

@bording
Copy link
Collaborator

bording commented Jul 26, 2018

@adamralph Currently, yes I believe that is true, but that should be changing "soon". Microsoft is going to be adding the capability to pull down .NET Framework targeting packs via NuGet, so the SDK will be able to compile net451 on any OS.

@adamralph
Copy link
Contributor

@bording thats great to hear. IIRC I saw something about that on Twitter recently too.

I guess it's orthogonal to this issue though. Should this issue be reopened? I think it's reasonable to regard this issue as simply adding a netstandard 2.0 target, where #429 is something else.

@michaelklishin michaelklishin changed the title Nugetspec update for netStandard2.0 Add .NET Standard 2.0 support in addition to 1.5 Jul 26, 2018
@michaelklishin
Copy link
Member

We'd welcome a PR for this specific change. See #429 for dropping pre-2.0 version support [in a future version]. Thank you @adamralph for your input, as always ❤️.

@michaelklishin
Copy link
Member

New target was added in #435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants