Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make a version for .net Core 2.0 #45

Closed
kooboo-binbin opened this issue Jan 25, 2018 · 14 comments
Closed

Please make a version for .net Core 2.0 #45

kooboo-binbin opened this issue Jan 25, 2018 · 14 comments

Comments

@kooboo-binbin
Copy link

Please make a version for .net Core 2.0

@imaji
Copy link
Contributor

imaji commented Mar 28, 2018

Hi,

Yes, we're just looking at timescales to make a .net standard compliant version.

I haven't got a date for you yet though.

Best regards,
John

@nicolasguzca
Copy link

Hi John, any updates on the .net Core 2.0 version?

@justin-lavelle
Copy link

justin-lavelle commented May 5, 2018

I have a fork for netstandard2.0 https://github.com/justin-lavelle/pusher-websocket-dotnet-netstandard
It's also on nuget PusherClient.NetStandard

@Misiu
Copy link

Misiu commented Nov 30, 2018

@justin-lavelle could You make a PR with all the changes?

@imaji
Copy link
Contributor

imaji commented Nov 30, 2018

I've got a version we're going to merge in shortly that adds in support for .net standard 1.6 & 2.0

@Misiu
Copy link

Misiu commented Nov 30, 2018

@imaji awesome news 😄

@bddckr
Copy link

bddckr commented Dec 6, 2018

Will the Standard compliant version still include WebSocket4Net or is System.Net.WebSockets.ClientWebSocket enough?

I'm having a hard time figuring out whether it supports the same OS/device combinations besides being part of .NET Standard 2.0 and whether that's an issue for this library.

@Misiu
Copy link

Misiu commented May 21, 2019

@imaji any updates?

@Misiu
Copy link

Misiu commented Jun 12, 2019

ping

@kn100
Copy link
Contributor

kn100 commented Jun 24, 2019

Hi @Misiu - I will also bring this up in our next standup and keep you up to date on our plans.

@Misiu
Copy link

Misiu commented Jul 10, 2019

@kn100 any updates?
I've noticed that recent PR added support for neststandard1.6, why can't You add both?
netstandard2.0 has a smaller dependency tree, so it is preferred by many developers.
Take a look at how RabbitMQ did it:rabbitmq/rabbitmq-dotnet-client#428 (comment)

@Misiu
Copy link

Misiu commented Aug 26, 2019

@damdo any updates?

@damdo
Copy link
Contributor

damdo commented Jan 30, 2020

Hey all! So currently the library supports .NET standard 1.6, but yes .NET standard 2.0 (and thus .NET Core 2.0) is on our radar. We are currently focused on improving certain behaviours of the library / fixing some issues, but extending the compatibility is next 👍

@elverkilde
Copy link
Contributor

This issue was fixed in #104 which was released as version 2.0.0. Please be aware that this is a major release, with several breaking changes. We have written a migration guide here:

https://github.com/pusher/pusher-websocket-dotnet#migrating-from-version-1-to-version-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants