Support cancellation #1420
Comments
|
FYI since cooperative cancelation is up to the implementor to decide where and when cancelation can be triggered it might be OK to start adding the token to the public async APIs and then start implementing and further evolve it over time (example in minors) |
lukebakken
added a commit
that referenced
this issue
Dec 11, 2023
Part of the fix to #1420 Use a linked token source to combine external cancellation and timeout cancelltion for initial RMQ connection Fix API since we have to use the same for all target frameworks. Fix the order of operations when establishing a connection. Add missing ConfigureAwait Add some more missing ConfigureAwait(false) statements. A timeout of 1 second can result in OperationCanceledException Validate hostname in SocketFrameHandler to restore expectation that an exception will be thrown. Ugh. Increase connection timeout for CI Add helpful message to connection failure. Fix tests in a very ugly way. Much TODO Make endpoint resolver SelectOne async. Pass on CancellationToken Pass cancellation token into more connection establishment methods. Fix expected exception for net472 Use Async method otherwise GetAwaiter/GetResult locks up Change expected exception type Increase connection timeout for CI due to slow runners Try out idea to fix odd CI error in GHA Bump version Upgrade dependencies. Modify Windows GHA setup to explicitly create firewall rules for Erlang programs. Tweak setting up firewalls on Windows Use Get-Random to help ensure unique fw rule names
|
#1535 added the last of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reference: comment
@danielmarbach points out that the async API should support cancellation.
The text was updated successfully, but these errors were encountered: