Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better topology examples #846

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

EnessenE
Copy link
Contributor

@EnessenE EnessenE commented Jul 1, 2024

This closes nothing.

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

Simply add some additional comments and examples to the topology examples made available.

Additional Context

@vmwclabot
Copy link

@EnessenE, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@EnessenE, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@Zerpet Zerpet added this to the v1.14.3 milestone Jul 4, 2024
EnessenE and others added 2 commits July 4, 2024 16:46
Co-authored-by: Aitor Pérez Cedres <1515757+Zerpet@users.noreply.github.com>
@EnessenE EnessenE marked this pull request as ready for review July 4, 2024 15:17
@EnessenE EnessenE requested a review from Zerpet July 4, 2024 15:18
@Zerpet
Copy link
Contributor

Zerpet commented Jul 4, 2024

We will have to wait for the CLA approval before merging. Thank you for this contribution!

@EnessenE
Copy link
Contributor Author

EnessenE commented Jul 4, 2024

Thanks for the quick review!

@Zerpet Zerpet merged commit 6880b0f into rabbitmq:main Jul 23, 2024
2 checks passed
@vmwclabot
Copy link

@EnessenE, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants