[COOK-3078] Escape and quote password before using #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,7 +76,8 @@ def user_has_permissions?(name, vhost, perm_list = nil) | |||
| if new_resource.password.nil? || new_resource.password.empty? | |||
| Chef::Application.fatal!("rabbitmq_user with action :add requires a non-nil/empty password.") | |||
| end | |||
| cmdStr = "rabbitmqctl add_user #{new_resource.user} #{new_resource.password}" | |||
| new_password = new_resource.password.gsub("'", "'\\\\''") | |||
There was a problem hiding this comment.
a comment here explaining why we need so much escaping would be good.
|
@btm: I have added a hopefully useful comment |
|
@vhata NICE! Thanks :D |
jtimberman
pushed a commit
that referenced
this pull request
Jun 4, 2013
[COOK-3078] Escape and quote password before using
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The password is not quoted in the add_user command, so any password with spaces will fail with "invalid command" due to too many arguments. This adds quotes around the password, and of course escapes any quotes inside the password.