Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ubuntu Erlang Install Issue #526

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

devsibwarra
Copy link
Contributor

@devsibwarra devsibwarra commented Apr 26, 2019

Proposed Changes

The Ubuntu packager tries to satisfy dependencies when erlang-base is installed. Since this occurred before the other erlang-* packages are pinned, this causes incompatible versions to be installed. This PR updates the logic to manage all Debian packages at the same time.

While messing around in the provider code, I noticed the removal logic for non-debian platforms stuck inside the debian block.

Types of Changes

  • Bug fix (non-breaking change which fixes Pinned Erlang fails to install from Bintray on Ubuntu #525 )
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinned Erlang fails to install from Bintray on Ubuntu
2 participants