Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more TLS socket options, enable them by default #487

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

michaelklishin
Copy link
Member

Proposed Changes

This adds support for a several more TLS socket options to ensure
that the recommendations/setup from http://www.rabbitmq.com/ssl.html#tls-evaluation-tools is
possible to achieve with this cookbook.

Types of Changes

  • Bug fix (non-breaking change which fixes issue Support additional ssl_options for security #240)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #240.

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rake spec passes, changes look good to me 👍

@lukebakken lukebakken merged commit dc67051 into master Feb 21, 2018
@lukebakken lukebakken deleted the chef-cookbook-240 branch February 21, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants