Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TCP buffer size configurable #486

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Make TCP buffer size configurable #486

merged 2 commits into from
Feb 21, 2018

Conversation

michaelklishin
Copy link
Member

Proposed Changes

This PR makes TCP buffer size and credit flow defaults configurable, as requested in #459.

Types of Changes

  • Bug fix
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #459.

As well as credit flow defaults.

Closes #459.
@lukebakken
Copy link
Contributor

We could add buffer as well, since this code selects the max of sndbuf, recbuf and buffer to use for the socket buffer size - what do you think @michaelklishin ?

@lukebakken lukebakken merged commit 3418e04 into master Feb 21, 2018
@lukebakken lukebakken deleted the chef-cookbook-459 branch February 21, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants