Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to override TCP listener interface #485

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Make it possible to override TCP listener interface #485

merged 1 commit into from
Feb 21, 2018

Conversation

michaelklishin
Copy link
Member

Proposed Changes

This PR makes it possible to override TCP listener interface.

The attributes used mimic those for TLS listeners. This
is not optimal because there is no way to set multiple
listeners, so this is something that is worth revisiting in 6.0.

Types of Changes

  • Bug fix (non-breaking change which fixes issue Allow to set tcp_listeners #364)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #364.

lukebakken
lukebakken approved these changes Feb 20, 2018
View reviewed changes
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test for ssl_port and updated the README

@lukebakken lukebakken force-pushed the chef-cookbook-364 branch 2 times, most recently from 4e77efe to ca91015 Compare February 21, 2018 21:44
@michaelklishin @lukebakken
Make it possible to override TCP listener interface
47952db 
The attributes used mimic those for TLS listeners. This
is not optimal because there is no way to set multiple
listeners, so this is something that is worth revisiting in 6.0.

Closes #364.

Fix ssl specs, add test for ssl_port
@lukebakken lukebakken merged commit 71926e8 into master Feb 21, 2018
@lukebakken lukebakken deleted the chef-cookbook-364 branch February 21, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

@jjasghar jjasghar Awaiting requested review from jjasghar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelklishin @lukebakken