Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a config root resource, closes #351 #484

Merged
merged 2 commits into from
Feb 21, 2018
Merged

Add a config root resource, closes #351 #484

merged 2 commits into from
Feb 21, 2018

Conversation

michaelklishin
Copy link
Member

Proposed Changes

This adds a directory resource that creates config root, as requested in #351.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Please add directory resource for config_root #351)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Closes #351.

@michaelklishin michaelklishin modified the milestone: 5.6.0 Feb 19, 2018
devsibwarra
devsibwarra reviewed Feb 20, 2018
View reviewed changes
recipes/default.rb Outdated
directory node['rabbitmq']['config_root'] do
owner 'root'
group 'root'
mode '0440'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you want a mode of 0755 for the directory

spec/default_spec.rb Outdated
.with(
:user => 'root',
:group => 'root',
:mode => '0440'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directory mode 0755?

@lukebakken lukebakken merged commit 7609aa3 into master Feb 21, 2018
@lukebakken lukebakken deleted the chef-cookbook-351 branch February 21, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsibwarra devsibwarra devsibwarra left review comments

@lukebakken lukebakken lukebakken approved these changes

@jjasghar jjasghar Awaiting requested review from jjasghar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelklishin @lukebakken @devsibwarra