Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clustering work #48

Merged
merged 4 commits into from May 21, 2013
Merged

Make clustering work #48

merged 4 commits into from May 21, 2013

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2013

@michaelklishin
Copy link
Member

@tchoi80 hardcoding node names in a cookbook is not a good idea. Neither is changing the default value
of node[:rabbitmq][:cluster].

Also note that running

rabbitmqctl stop_app && rabbitmqctl reset && rabbitmqctl start_app

is not equivalent to stopping the service. This will stop the app, reset the database (!!) and start it back. I don't think
resetting the database on every run is a very good idea either.

@ghost
Copy link
Author

ghost commented Apr 30, 2013

@michaelklishin,
OK. I reverted the attributes to their default values.

For the 'reset' command, it's not for stopping service, but for resetting the database as you said.
(Stopping service is done by 'execute' resource in the middle.)
And it isn't called on every run! Once the cookie is set, the block won't be called from next run!

jtimberman pushed a commit that referenced this pull request May 21, 2013
@jtimberman jtimberman merged commit a3c2084 into rabbitmq:master May 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants