add the ability to load definitions on start #472
Conversation
efccf6a to
cfa0b17
Compare
|
Just did an amend to the commit. Would you like me to document the feature? |
|
@esabelhaus that would be appreciated. I suggest we add a new README section on definitions. Thanks for the quick turnaround, by the way. |
cfa0b17 to
5e25ef4
Compare
|
@michaelklishin added a blurb in the Readme.md, let me know if that will suffice. |
|
Thank you! |
| @@ -132,6 +132,10 @@ | |||
| default['rabbitmq']['web_console_ssl'] = false | |||
| default['rabbitmq']['web_console_ssl_port'] = 15_671 | |||
|
|
|||
| # If configured to true, allows downstream cookbooks to supply definitions on start | |||
| default['rabbitmq']['management']['load_definitions'] = false | |||
| default['rabbitmq']['management']['definitions_file'] = '/etc/rabbitmq/load_definitions.json' | |||
There was a problem hiding this comment.
I'd suggest replacing /etc/rabbitmq with node['rabbitmq']['config_root'] for compatibility with different platforms
| <% if node['rabbitmq']['management']['load_definitions'] %> | ||
| {load_definitions, "<%= node['rabbitmq']['management']['definitions_file'] %>"} | ||
| ]} | ||
| <% end -%> |
There was a problem hiding this comment.
This looks like it will close the rabbitmq_management config section too early. If you've already tested these changes and it builds a valid config file, feel free to ignore this.
There was a problem hiding this comment.
Good catch. Should be corrected in 2b6fb6f.
There was a problem hiding this comment.
Looks like 2b6fb6f moves the load_definitions section under rabbitmq_management -> listener. Can't wait for the new config file format :)
There was a problem hiding this comment.
Corrected again and added the same thing to the non-HTTPS branch. Yeah, the new config format is going to make this stuff drastically simpler.
There was a problem hiding this comment.
I'm having trouble with my test kitchen setup, so a test for this may or may not land today but let's see what CI says.
This reverts commit 2b6fb6f. This would be so much less error prone if we only supported 3.7.0.
I would like to enable the ability to use the management plugins ability to load definitions.
I've set sane defaults to disable the feature, but it allows someone downstream to create a json file at
/etc/rabbitmq/load_definitions.json, and if the attribute is set to true, it would load those definitions defined in the json.Please let me know if I'm missing anything, and I'll update the PR accordingly.
-Haus