Ability to set interface to listen for SSL connections #470
Conversation
|
Please take a look at why the unit and lint Travis run fails. It's usually a relatively easy part to debug compared to integration tests. |
attributes/default.rb
Outdated
| @@ -113,6 +113,7 @@ | |||
| # ssl | |||
| default['rabbitmq']['ssl'] = false | |||
| default['rabbitmq']['ssl_port'] = 5671 | |||
| default['rabbitmq']['ssl_listen_interface'] = nil # will not be mentioned in config if left nil | |||
There was a problem hiding this comment.
That's the way it works for many attributes in many cookbooks, please leave this comment out.
There was a problem hiding this comment.
Or, at least move the comment above the line and make it say that the default will make RabbitMQ listen on all interfaces: that may or may not be obvious.
There was a problem hiding this comment.
Updated. Waiting for CI to complete.
There was a problem hiding this comment.
The failure looks not being related to changes:
1) rabbitmq::default ubuntu installs the rabbitmq-server deb_package with the default action
Will try to re-trigger test.
820113b to
5a980b1
Compare
|
@michaelklishin could you please review #471 ? It fixes the unit test that's failing builds for this PR. |
|
Was this really meant to be closed? Looks like #471 is an addition to this PR, not a replacement for it? |
|
I'm going to merge this and #471 at the same time manually. |
Attribute
node['rabbitmq']['ssl_listen_interface']is set will define specific interface to bind.May be filled with "0.0.0.0" (this will result in listening on IPv4 interfaces).
Will not affect existing config if left default (
nil)