Request for adding retry to node start #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
requested changes
Aug 3, 2017
recipes/default.rb
Outdated
| @@ -252,6 +252,8 @@ class Chef::Resource | |||
|
|
|||
| if node['rabbitmq']['manage_service'] | |||
| service node['rabbitmq']['service_name'] do | |||
| retry node['rabbitmq']['retry'] | |||
There was a problem hiding this comment.
According to Chef docs this should be retries.
|
@jjasghar I still think that those two attributes would be useful to have. Any objections? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we are noticing is that every time it get reconvered after the VM delete senario it failed once on second attempt it works so adding a retry to start the node, keeping values to defualt so no chang eofr anyone using cookbook but you can override defaults if you wanted to set to something else