Fix resource cloning deprecation warnings #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
bdwyertech
suggested changes
May 15, 2017
| # Manual clustering | ||
| unless node['rabbitmq']['clustering']['use_auto_clustering'] | ||
| # Join in cluster | ||
| rabbitmq_cluster cluster_nodes do | ||
| rabbitmq_cluster auto_cluster_nodes do |
There was a problem hiding this comment.
Maybe Instead of creating those two variables, create a unique name for the rabbitmq_cluster resource, e.g.
rabbitmq_cluster "Join Cluster (#{node['rabbitmq']['clustering']['cluster_name']})" do
cluster_nodes cluster_nodes
cluster_name node['rabbitmq']['clustering']['cluster_name']
action :join
end| cluster_name node['rabbitmq']['clustering']['cluster_name'] | ||
| action :join | ||
| end | ||
| end | ||
|
|
||
| # Set cluster name : It will be skipped once same cluster name has been set in the cluster. | ||
| rabbitmq_cluster cluster_nodes do | ||
| rabbitmq_cluster static_cluster_nodes do |
There was a problem hiding this comment.
Maybe something here like
rabbitmq_cluster "Configure Cluster (#{node['rabbitmq']['clustering']['cluster_name']})" do
cluster_nodes cluster_nodes
cluster_name node['rabbitmq']['clustering']['cluster_name']
action [:set_cluster_name, :change_cluster_node_type]
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.chef.io/deprecations_resource_cloning.html