Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not restart RabbitMQ for Policy Change #445

Merged
merged 1 commit into from
May 14, 2017

Conversation

bdwyertech
Copy link
Contributor

@bdwyertech bdwyertech commented May 14, 2017

Addresses #441

We don't have to restart RabbitMQ to apply policies.

The changes in #425 will cause these notifications to fire on every Chef run.

Straight from https://www.rabbitmq.com/parameters.html

Policies can change at any time. 
When a policy definition is updated, its effect on matching exchanges and queues will be reapplied.
Usually it happens instantaneously but for very busy queues can take a bit of time (say, a few seconds).

The RabbitMQ documentation states that policy changes are applied in real-time
@michaelklishin
Copy link
Member

@jjasghar LGTM. Should I merge?

@jjasghar jjasghar merged commit 0e031f4 into rabbitmq:master May 14, 2017
@jjasghar
Copy link
Contributor

I'll release a new version soon. I'm going to revisit the PRs and ideally get a new release cut on the 18th.

@bdwyertech
Copy link
Contributor Author

bdwyertech commented May 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants