Update to default.rb library to handle frozen strings #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Chef 13, the prepend method on the string is failing due to Chef freezing objects. By moving the extra whitespace characters to the original array, we are able to bypass that frozen object failure which just leaves us with joining the items.
Update default.rb
|
If you are actually adding kernel options, without this change, Chef 13 will throw an error. |
|
Awesome! thanks for this! |
devsibwarra
reviewed
Apr 12, 2017
| end | ||
|
|
||
| rendered.each { |r| r.prepend(' ') }.join(",\n") | ||
| rendered.each { |r| r }.join(",\n") |
There was a problem hiding this comment.
Is there a reason to keep .each {} for this line or can it go away?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under Chef client 13, Chef issues an error on the prepend method for the string because the strings are frozen objects. By moving the whitespace characters to the original array creation, we can do a simple non-destructive join, which solves the issue of not being allowed to change a frozen string in chef.