Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename params property to parameters #427

Merged

Conversation

shortdudey123
Copy link
Contributor

This cleans up the resource property errors.

Note: This is a breaking change

================================================================================
Recipe Compile Error in /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb
================================================================================
ArgumentError
-------------
Property `params` of resource `rabbitmq_parameter` overwrites an existing method.
Cookbook Trace:
---------------
  /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:28:in `class_from_file'
Relevant File Content:
----------------------
/opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:
 21:
 22:  actions :set, :clear, :list
 23:  default_action :set
 24:
 25:  attribute :parameter, :kind_of => String, :name_attribute => true
 26:  attribute :component, :kind_of => String
 27:  attribute :vhost, :kind_of => String
 28>> attribute :params, :kind_of => [Hash, Array], :default => {}
 29:
Platform:
---------
x86_64-linux

This cleans up the resource property errors.

Note: This is a breaking change

```
================================================================================
Recipe Compile Error in /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb
================================================================================
ArgumentError
-------------
Property `params` of resource `rabbitmq_parameter` overwrites an existing method.
Cookbook Trace:
---------------
  /opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:28:in `class_from_file'
Relevant File Content:
----------------------
/opt/kitchen/cache/cookbooks/rabbitmq/resources/parameter.rb:
 21:
 22:  actions :set, :clear, :list
 23:  default_action :set
 24:
 25:  attribute :parameter, :kind_of => String, :name_attribute => true
 26:  attribute :component, :kind_of => String
 27:  attribute :vhost, :kind_of => String
 28>> attribute :params, :kind_of => [Hash, Array], :default => {}
 29:
Platform:
---------
x86_64-linux
```
@shortdudey123
Copy link
Contributor Author

Note: TravisCI tests are still failing, however, they are due to other issues that are now being uncovered

@michaelklishin
Copy link
Member

Thank you. I guess it's time for a version bump.

@jjasghar jjasghar merged commit 99ccab4 into rabbitmq:master Apr 8, 2017
@shortdudey123 shortdudey123 deleted the fix_resource_property_override branch April 8, 2017 23:39
@erulabs
Copy link

erulabs commented Apr 12, 2017

@michaelklishin Any word on the version bump? This is the only cookbook blocking chef13 for the sensu cookbook which relies on this one in turn :)

@michaelklishin
Copy link
Member

@jjasghar can we release a 5.0 with this?

@jjasghar
Copy link
Contributor

Will do

@michaelklishin
Copy link
Member

@jjasghar ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants