reassign variable with frozen string instead of appending to it #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Does this fix your original problem too? |
|
Yeah, this deploys just fine now. |
|
Perfect, i'll push out this fix asap. |
|
Awesome, thanks! |
|
@brendenyule thank you! |
|
@michaelklishin np. Thanks for the help guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to change string variables without actually mutating them.
This allows these files to be compatible with ruby 3.0 in the future.
Ruby 3.0 will have frozen strings, which prevents the
<<operator from working, because it attempts to mutate a frozen string.Using the
+=operator reassigns the original variable instead of mutating it.Fixes #422