Fixes for rhel based pkgs #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes for rhel based pkgs Signed-off-by: JJ Asghar <jj@chef.io>
attributes/default.rb
Outdated
| when > '6' | ||
| default['rabbitmq']['rpm_package'] = "rabbitmq-server-#{node['rabbitmq']['version']}-1.el6..noarch.rpm" | ||
| when < '6' | ||
| default['rabbitmq']['rpm_package'] = "rabbitmq-server-#{node['rabbitmq']['version']}-1.el7.noarch.rpm" |
There was a problem hiding this comment.
This looks like a typo? For versions < 6 this uses the CentOS 7 package?
There was a problem hiding this comment.
Also, we should cover the case where version equals 6? ;)
attributes/default.rb
Outdated
| default['rabbitmq']['rpm_package'] = "rabbitmq-server-#{node['rabbitmq']['version']}-1.el7.noarch.rpm" | ||
| end | ||
| when 'suse' | ||
| default['rabbitmq']['rpm_package'] = "rabbitmq-server-#{node['rabbitmq']['version']}-1.suse..noarch.rpm" |
There was a problem hiding this comment.
Is there an extra dot before the noarch?
|
@jjasghar thank you! I see a couple of suspicious things (likely typos) in this PR. |
added 2 commits
March 17, 2017 16:45
Typos Signed-off-by: JJ Asghar <jj@chef.io>
attributes/default.rb
Outdated
| case node['platform_family'] | ||
| when 'rhel', 'fedora' | ||
| case node['platform_version'] | ||
| when < '6' |
There was a problem hiding this comment.
I think this should be <= as currently version 6 will match the other branch.
missed = Signed-off-by: JJ Asghar <jj@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JJ Asghar jj@chef.io