Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attributes from the metadata #406

Merged
merged 2 commits into from
Jan 6, 2017
Merged

Remove attributes from the metadata #406

merged 2 commits into from
Jan 6, 2017

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jan 5, 2017

We don't use these anywhere and they're generally wrong

tas50 added 2 commits January 5, 2017 15:07
We don't use these anywhere and they're generally wrong
@jjasghar jjasghar merged commit 118be03 into rabbitmq:master Jan 6, 2017
:description => 'A list of lines to append to rabbitmq-env.conf for settings that may not yet be available with existing attributes',
:default => nil,
:type => 'array'
supports 'ubuntu', '>= 14.04'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline at EOF might make rubocop unhappy, unless you're ignoring that cop

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll make sure that 5.0.0 has rubocop happy before releasing it.

@tas50 tas50 deleted the patch-1 branch January 6, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants