Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added socat #372

Merged
merged 2 commits into from
Jun 2, 2016
Merged

Added socat #372

merged 2 commits into from
Jun 2, 2016

Conversation

jjasghar
Copy link
Contributor

@jjasghar jjasghar commented Jun 2, 2016

  • A new dependancy for RabbitMQ

Added socat
19e8717 
- A new dependancy for RabbitMQ
@jjasghar jjasghar mentioned this pull request Jun 2, 2016
Closed
devsibwarra
devsibwarra reviewed Jun 2, 2016
View reviewed changes
recipes/default.rb
@@ -90,6 +94,10 @@ class Chef::Resource # rubocop:disable all
end

when 'rhel', 'fedora'

# socat is a package dependency of rabbitmq-server
package 'socat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing quote

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's why we have Code reviews! /me walks away sheepishly :P

@michaelklishin
Copy link
Member

👍

@jjasghar jjasghar merged commit 31fb06b into master Jun 2, 2016
@jjasghar jjasghar deleted the socat branch June 2, 2016 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjasghar @michaelklishin @devsibwarra