Update cipher examples #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating examples of cipher suites to match rspec tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR matches the example ciphers in the attributes file to the current rspec tests.
4480a86 was a backwards compatibility breaking change for me. I'm not sure if it's the version of rabbit that I'm using, but the only valid configuration I get is when the openssl ciphers are double quoted (not single quoted) or the standard cipher strings are wrapped in curly braces. It was previously valid to just specify the cipher suite as an array of strings so long as they weren't in the Openssl format, now they must be an array of curly brace wrapped strings.
These examples would have made it a lot quicker to realise there was a change.
I would ask that you please increment the metadata version by a major version increment if backward compatibility breaking changes are introduced, so that the pessimistic matcher can work (i.e. depends 'rabbitmq', '~> 0.1')