Pass a HOME environment variable to all rabbitmq execute blocks #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Just need another 👍 |
| @@ -51,6 +51,7 @@ def parameter_exists?(vhost, name) | |||
|
|
|||
| execute "set_parameter #{parameter}" do | |||
| command cmd | |||
| environment 'HOME' => ENV.fetch('HOME', '/root') | |||
There was a problem hiding this comment.
Wouldn't /var/lib/rabbitmq be a better fallback value?
There was a problem hiding this comment.
If so, should I change it to that in the places where /root was already being set as well?
There was a problem hiding this comment.
I think so. RabbitMQ or its CLI tools are typically do not run as root. Granted, /var/lib/rabbitmq isn't portable but it's the most sensible fallback value I can come up with.
25ef1d0 to
fb7a13e
Compare
|
At @michaelklishin's suggestion, updated all the fallback home dirs to |
jjasghar
pushed a commit
that referenced
this pull request
Mar 8, 2016
Pass a HOME environment variable to all rabbitmq execute blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #334 today when rolling some new Rabbitmq servers. Since the
ShellOuts are already ensuring the presence of aHOMEenvironment variable, it seemed logical to have theexecuteblocks do the same. Agree/disagree/thoughts?Thanks!