Enable chef setting for tcp_listen linger option

[mgosalia]

No description provided.

[mgosalia]

@jjasghar could you please review this ?
Reference - https://www.rabbitmq.com/networking.html
grep for "linger".

[jjasghar]

I'll take a look at this, and do some research on this.

@michaelklishin any thoughts on this option? This is the first i've heard of it.

[mgosalia]

@michaelklishin fyi...I had sent out an email to openstack-operators mailing list as well.
Here is the email - http://lists.openstack.org/pipermail/openstack-operators/2015-November/008878.html

[mgosalia]

Thanks @jjasghar

[michaelklishin]

Socket lingering is primarily useful to clients but I have no objections to this. Keep in mind that as of 3.6.0 we will be using a TCP acceptor library called Ranch, which has sensible defaults for most, and is fairly strict about rejecting options it doesn't support (in general, the options are nearly identical to gen_tcp, though).

[mgosalia]

@michaelklishin do we know for sure that linger {true, 0} is always the default setting in rabbitmq config ?
This documentation [1] does say so.

[1] - https://www.rabbitmq.com/networking.html

[michaelklishin]

@mgosalia see for yourself:

• in master
• in stable

[mgosalia]

Thanks @michaelklishin.
@jjasghar is it good to go ? This change will help us at Yahoo to configure the value.

[jjasghar]

I'm going to run this through our testing today. Any chance you can create an integration/unit test for this? I really don't like adding things to this cookbook without test coverage.

[mgosalia]

@jjasghar sure...will add unit tests. I tried to look for existing tests related to rabbitmq config and did not find any. So, had skipped it. Let me dig more.

[jjasghar]

Sounds good, just Unit tests are probably fine. When you get them added I'll go through my release process and get this pushed out.

[mgosalia]

@jjasghar have updated the change with unit tests. Could you please review it again ? Thanks.

[jjasghar]

Awesome, thanks. I'll run some final tests and push out a new version ASAP.